Skip to content

Conversation

colleenmcginnis
Copy link
Contributor

Replace AsciiDoc API links that should redirect to the new API docs. For more details, refer to https://github.com/elastic/docs-projects/issues/414#issuecomment-2654939177.

@natasha-moore-elastic
Copy link
Contributor

natasha-moore-elastic commented Feb 13, 2025

Hey @colleenmcginnis, I'm wondering why no Security files are included in this PR? We don't have too many instances of linking to our API docs in Security, but I know we have some (one example here).


`chunking_settings`
: (Optional, object) Chunking configuration object. Refer to [Configuring chunking](https://www.elastic.co/guide/en/elasticsearch/reference/current/inference-apis.html#infer-chunking-config) to learn more about chunking.
: (Optional, object) Chunking configuration object. Refer to [Configuring chunking](https://www.elastic.co/docs/api/doc/elasticsearch/group/endpoint-inference) to learn more about chunking.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this link doesn't make sense anymore because that information is not in the new reference yet

This holds for all of these ones in the inference-api directory.

cc @szabosteve @charlotte-hoblik

we might just have to remove these links entirely for the moment until that chunking information is restored somewhere centrally? LMKWYT

Copy link
Contributor

@leemthompo leemthompo Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colleenmcginnis feel free to ignore this and we'll create a TODO to handle it next week :)

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Some links needed to be more targeted

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more, sorry my internet is choppy so had to chunk this review 🙈

Co-authored-by: Liam Thompson <[email protected]>
@colleenmcginnis
Copy link
Contributor Author

colleenmcginnis commented Feb 13, 2025

Hey @colleenmcginnis, I'm wondering why no Security files are included in this PR? We don't have too many instances of linking to our API docs in Security, but I know we have some (one example here).

This example should be covered in #435. This PR is only covering files currently in the solutions directory.

Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@colleenmcginnis colleenmcginnis enabled auto-merge (squash) February 13, 2025 16:19
@colleenmcginnis colleenmcginnis merged commit 9fe72b6 into main Feb 13, 2025
4 of 6 checks passed
@leemthompo leemthompo deleted the replace-api-links-solutions branch February 14, 2025 10:54
colleenmcginnis added a commit that referenced this pull request Feb 20, 2025
Rerun API redirect script to catch links added/changed since #430 #431
#432 #433 #434 #435.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants